Skip to content

Conversation

OliviaShoup
Copy link
Contributor

@OliviaShoup OliviaShoup commented Aug 4, 2025

What does this PR do? What is the motivation?

This PR updates information about running apps as author.

Merge instructions

Merge readiness:

  • Ready for merge

@OliviaShoup OliviaShoup requested a review from barakshush August 4, 2025 18:55
@OliviaShoup OliviaShoup requested a review from a team as a code owner August 4, 2025 18:55
Copy link
Contributor

github-actions bot commented Aug 4, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@brett0000FF brett0000FF self-assigned this Aug 4, 2025
@brett0000FF brett0000FF added the Do Not Merge Just do not merge this PR :) label Aug 4, 2025
@barakshush
Copy link

Barak's feedback:

  1. I see that the sidebar says: "Authentication" while the title says "Access and Authentication", can we make them aligned?
  2. For this section: "Instead, actions use the identity of the app’s author" can we explain how to view who's the author of the app? see a screenshot below
image

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Aug 6, 2025
@OliviaShoup OliviaShoup added editorial review Waiting on a more in-depth review and removed Do Not Merge Just do not merge this PR :) Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review labels Aug 13, 2025
@janine-c janine-c self-assigned this Aug 14, 2025
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Looks like there are still some links that go to the old filenames, so we want to make sure we catch those before merging. The internal page we have on moving docs pages is also good for making sure we don't break links when we move pages, even though none of these pages have moved 🙂

If you could do a search to update those links, and add aliases to both pages so their old URLs work, that would be great! Let me know if you'd like to show you how I do it.

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Aug 14, 2025
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes I mentioned and tested them all 🙂 Feel free to take a look and merge whenever is convenient for you!

@OliviaShoup OliviaShoup merged commit 465d8fc into master Aug 15, 2025
13 of 14 checks passed
@OliviaShoup OliviaShoup deleted the olivia.shoup/docs-9616 branch August 15, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants